Re: Ported some PHP5 PECL extensions to PHP7

Hi, Thanks for fix. I have created repository in github: https://github.com/esminis/php_pecl_rar If you can - create pull request (if you can`t then I can of course copy paste but there will be no references to you). And about TS build - you will probably need some #ifdef because seems that if ZTS is defined it is different, see #define RAR_G(v) in php_rar.h I will look into this sometime later(not exactly sure when) if you won`t. After windows version is fixed I will try to do pull request to main repository maybe maintainer will accept it. On 02/28/2016 04:36 AM, Jan Ehrhardt wrote:

Jan Ehrhardt in php.pecl.dev (Sat, 27 Feb 2016 13:48:13 +0100):

Tautvydas in php.pecl.dev (Sat, 27 Feb 2016 09:13:51 +0200):

Here are source repositories: https://bitbucket.org/esminis/php_pecl_rar

Wonderful job! Could somebody with karma give Tautvydas access to the PECL sources, please?

And rar has some problems with VC14. TS x64: rar_stream.c(923): error C2198: 'function through pointer': too few arguments for call rar_stream.c(962): error C2198: 'function through pointer': too few arguments for call rar_stream.c(964): error C2198: 'function through pointer': too few arguments for call NTS x64: dll.obj : error LNK2001: unresolved external symbol "void __cdecl cleandata(void *,unsigned __int64)" (?cleandata@@YAXPEAX_K@Z) crypt.obj : error LNK2019: unresolved external symbol "public: __cdecl SecPassword::SecPassword(void)" (??0SecPassword@@QEAA@XZ) referenced in function "public: __cdecl CryptKeyCache Item::CryptKeyCacheItem(void)" (??0CryptKeyCacheItem@@QEAA@XZ)

I fixed the NTS builds. Config.w32 did not include secpassword.cpp: https://github.com/Jan-E/php_pecl_rar7/commit/b9c6922c4677ffc5759669d530664c302b967686 @Tautvydas please adjust your config.w32 as well. I did not fix the TS builds yet. There are arguments missing in the .get() and .put() functions in https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L923 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L961 https://github.com/Jan-E/php_pecl_rar7/blob/master/rar_stream.c#L964 Does anyone know how to fix the TS builds (Windows, VC14)? Jan