Re: Ported some PHP5 PECL extensions to PHP7

Yes I have backup of bitbucket repo(I can push to separate branch or send as zip to you), but I did not quite understand why you need it for PHP5 - there were only PHP7 rewrite, nothing more. On 02/28/2016 01:02 PM, Jan Ehrhardt wrote:

Tautvydas in php.pecl.dev (Sun, 28 Feb 2016 09:57:41 +0200):

I have created repository in github: https://github.com/esminis/php_pecl_rar If you can - create pull request (if you can`t then I can of course copy paste but there will be no references to you).

2 PR's created (with due reference to @weltling).

And about TS build - you will probably need some #ifdef because seems that if ZTS is defined it is different, see #define RAR_G(v) in php_rar.h I will look into this sometime later(not exactly sure when) if you won`t.

The same code is used in the PHP5 version, without #ifdef's. Something must have changed in the ZTS version of RAR_G(v) or VC14 is more strict than VC11 was. I do not know how to fix it.

After windows version is fixed I will try to do pull request to main repository maybe maintainer will accept it.

OK.

https://bitbucket.org/esminis/php_pecl_rar

It is a pity you deleted that repo, because the history of the non-PHP7 commits is now lost. I wanted to improve the PHP5 branch with your findings, but cannot do that anymore. Do you still have the commit history as it was on bitbucket? Jan