Re: pdo comments

Wez Furlong wrote:

4) do you think it would make sense to convert empty strings on insert as well if PDO_ATTR_ORACLE_NULLS is set and prepared statements are used

IMO, no.

The thing is though that in oracle the are converted on insert and not when you fetch the data. Therefore this could result in portability issues, that seem easy to solve.

6) Does it make sense to have fetch() as part of the statement object instead of having result sets having their own class?

It's less painful to use having the the result set merged into the statement handle, so IMO (and that of the perl guys) this is better than having a separate result set class.

Well it seems to be a little odd from a design perspective and I dont really see the advantage besides having one less class. But beyond that it mixes two totally separate things. A statement doesnt necessarily contain a result set. regards, Lukas