Re: Re: Adding runkit7 to PECL

Le 08/04/2019 à 13:31, Christoph M. Becker a écrit : > On 06.04.2019 at 18:19, tyson andre wrote: > >> This has been added as >> https://pecl.php.net/package/runkit7, but Windows builds fail. Is >> anyone able to change the Windows ./configure options? >> >> The output of configure and >> make are empty when building for Windows: >> https://windows.php.net/downloads/pecl/releases/runkit7/2.0.2/logs/ >> >> For the windows.php.net builds, I think they'd need to have the configure CLI options >> changed from the default (not sure what) to configure >> --enable-runkit. I'm not familiar with how this is changed. >> >> - This is buildable under Windows in Appveyor: >> https://github.com/runkit7/runkit7/blob/master/.appveyor.yml >> >> This has a name of runkit7, but <providesextension>runkit</providesextension> >> and builds runkit.so/runkit.dll, because the "runkit7" fork is a substitute that has the >> same function definitions as the php5 "runkit" PECL. That's probably related to the >> windows dll build issues. > > Hmm, not sure if it's the best idea to call the package runkit7, but the > extension runkit. This is likely confusing to users, and certainly for > the build system. Did you consider to rename this consistently? There is already a lot of extension where "project" name is different from the provided extension... - SeasLog => seaslog - SeasClick => seasclick - apcu_bc => apc - pecl_http => http - etc This have never been a blocking issue (despite same is simpler) Remi > > -- > Christoph M. Becker >

Attachment: [application/pgp-signature] OpenPGP digital signature signature.asc