Re: Re: Adding runkit7 to PECL

On Mon, 8 Apr 2019 at 14:59, Christoph M. Becker <cmbecker69@gmx.de> wrote: > > On 08.04.2019 at 13:52, Remi Collet wrote: > > > Le 08/04/2019 à 13:31, Christoph M. Becker a écrit : > > > >> On 06.04.2019 at 18:19, tyson andre wrote: > >> > >>> This has been added as > >>> https://pecl.php.net/package/runkit7, but Windows builds fail. Is > >>> anyone able to change the Windows ./configure options? > >>> > >>> The output of configure and > >>> make are empty when building for Windows: > >>> https://windows.php.net/downloads/pecl/releases/runkit7/2.0.2/logs/ > >>> > >>> For the windows.php.net builds, I think they'd need to have the configure CLI > >>> options changed from the default (not sure what) to configure > >>> --enable-runkit. I'm not familiar with how this is changed. > >>> > >>> - This is buildable under Windows in Appveyor: > >>> https://github.com/runkit7/runkit7/blob/master/.appveyor.yml > >>> > >>> This has a name of runkit7, but > >>> <providesextension>runkit</providesextension> and builds runkit.so/runkit.dll, because > >>> the "runkit7" fork is a substitute that has the same function definitions as the php5 > >>> "runkit" PECL. That's probably related to the windows dll build issues. > >> > >> Hmm, not sure if it's the best idea to call the package runkit7, but the > >> extension runkit. This is likely confusing to users, and certainly for > >> the build system. Did you consider to rename this consistently? > > > > There is already a lot of extension where "project" name is different > > from the provided extension... > > > > - SeasLog => seaslog > > - SeasClick => seasclick > > - apcu_bc => apc > > - pecl_http => http > > - etc > > > > This have never been a blocking issue > > (despite same is simpler) > > The difference here is that the runkit extension already exists. At > least for now, the rmtools[1] can't handle this. If we'd configure > real_name=runkit[2], the uploads would go into runkit's folder, causing > utmost confusion. Unless we adjust rmtools to this special case, we'd > have to do manual builds. > > [1] <http://git.php.net/?p=web/rmtools.git;a=summary> > [2] > > <http://git.php.net/?p=web/rmtools.git;a=blob;f=data/config/pecl/exts.ini;h=bdb9ff0b2f0bf757277a155abfb56bca5edac450;hb=HEAD#l24> > > -- > Christoph M. Becker > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > For PHP 8 branch the runkit7 PECL package (ex runkit) will be named runkit8? -- Peter Kokot