Re: safe_mode changes

From: Date: Sun, 19 Feb 2006 12:31:51 +0000
Subject: Re: safe_mode changes
References: 1 2  Groups: php.pecl.dev 
Request: Send a blank email to pecl-dev+get-3501@lists.php.net to get a copy of this message
On 2/19/06, Andi Gutmans <andi@zend.com> wrote: > Hey, > > I worked on a big patch for Pecl to nuke safe_mode. Before I commited > I noticed that not all extensions in Pecl seem to have a PHP_5_1 > branch (and definitely not a PHP_5_0) branch. My patch is for HEAD as > that's PHP 6.0 in the PHP CVS. Thanks for this cleaning effort :-) The problem is that php PHP_5_1 is HEAD in many extension and for windows builds (pecl4win). Despite the current effort, php6 does not really exist in the pecl world. > Any insight on how to go about this? If I just commit it seems that > certain modules which are rolled for PHP 5.1 from HEAD would not have > safe_mode anymore. I only want to remove it for PHP 6, not for PHP > 5.x. #ifdef would seriously suck, because one of the nice things > about this change is that it *really* cleans up a lot of code. I think you should let people apply it at wish. For example, I will clean my extension in pecl once HEAD actually exists in the wild or add #ifdef until a release exists (alpha/whatever). It is faster for me to maintain the #ifdef than merging, syncing and keeping tracks of changes in many branches. --Pierre

« previous php.pecl.dev (#3501) next »