Any insight on how to go about this? If I just commit it seems that certain modules which are rolled for PHP 5.1 from HEAD would not have safe_mode anymore. I only want to remove it for PHP 6, not for PHP 5.x. #ifdef would seriously suck, because one of the nice things about this change is that it *really* cleans up a lot of code.
While I certainly appreciate the effort you've put in, I think the only proper way to handle this is to not touch PECL exts (except perhaps the ones that actually have branching due to their inclusion in release bundles). Extension maintainers undestand that they may have to do some work to make their exts compatable with PHP6 changes anyway, this is just one of those.
I havn't looked, but I imagine very few do direct safe_mode checks themselves but rather leave it to the streams layer with a simple ENFORCE_SAFE_MODE flag. If we leave this define in place (resolving to 0 of course) then that particular compatability will be a non-issue. Only the exts that directly examine PG(safe_mode) and attempt to call the check uid methods will have to do any migration work which they can each apply with some well placed ifdefs.
Btw, are we getting an APINO bump with this change?
-Sara