Re: libzip?

On Jan 11, 2008 10:09 PM, Gregory Beaver <greg@chiaraquartet.net> wrote: > > Pierre wrote: > > On Jan 11, 2008 8:58 PM, Johannes Schlüter <johannes@php.net> wrote: > > > >> Hi, > >> > >> On Fri, 2008-01-11 at 13:23 -0600, Greg Beaver wrote: > >> > >>> Then do you mind if I begin work on the libzip inside pecl/zip? The > >>> problem right now is that zip and phar cannot be built statically at the > >>> same time, and it breaks gcov. The other alternative is removing all > >>> the work I just did integrating zip support into phar, and I would > >>> rather not do that over this if possible. > >>> > >> I don't think its a good idea to have the same lib 2 times, can't you > >> just add a dependency on ext/zip for people who want zip support? The > >> same as withzlib and bzip2 where you can't rely on them being there... > >> > > > > Indeed, especially now that the extension dependencies and loading order work. > > > > > I can when Pierre exports the symbols from libzip > > *ahem* > > but until then, no. If you have some times, please provide a patch, I can release it right after. I also think that it is not a problem to apply it to 5.2.x (I will ask Ilia). Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org