Re: Re: libpurple stage
| From: | Anatoliy Belsky | Date: | Sun, 13 Jan 2008 12:33:43 +0000 |
| Subject: | Re: Re: libpurple stage | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5070@lists.php.net to get a copy of this message | ||
Thank you for the corrections, i'm still a pupil.
I thought the arginfos are something like nice to have, so it's inentional ...
On Sunday 13 January 2008, Mikko Koppanen wrote:
> Looks pretty good!
>
>
> A few minor things I noticed in the code (correct me if I am wrong):
>
> 1) Constructors are not marked with ZEND_ACC_CTOR (not mandatory thou, but
> I think at least reflection uses that).
>
> 2) Arginfos are missing (intentional at this point?)
>
> 3) You're using TSRMLS_DC at call time, those should be TSRMLS_CC (CC =
> Comma Call vs DC = Declaration Call)