Re: Re: libpurple stage
| From: | Johannes Schlüter | Date: | Sun, 13 Jan 2008 12:52:53 +0000 |
| Subject: | Re: Re: libpurple stage | ||
| References: | 1 2 3 | Groups: | php.pecl.dev php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5071@lists.php.net to get a copy of this message | ||
Hi Mikko,
On Sun, 2008-01-13 at 12:05 +0000, "Mikko Koppanen" wrote:
> 1) Constructors are not marked with ZEND_ACC_CTOR (not mandatory thou, but I
> think at least reflection uses that).
The engine does that while registering the methods. No need to do it
yourself.
> 2) Arginfos are missing (intentional at this point?)
>
> 3) You're using TSRMLS_DC at call time, those should be TSRMLS_CC (CC =
> Comma Call vs DC = Declaration Call)
_DC = Declaration with comma
_CC = Call with comma
_C = Call (without comma)
_D = Declaration (without comma)
So "D" in function declaration, no D for calls, with comma when there
are other parameters, no C when TSRMLS is the only one.
It's always n good idea to test with --enable-maintainer-zts to find
missing/wrong TSRMs.
johannes