Re: cvs: pecl(PHP_5_2) /intl php_intl.c /intl/grapheme grapheme.h grapheme_string.c

On Wed, Apr 9, 2008 at 2:18 PM, Derick Rethans <derick@php.net> wrote: > On Wed, 9 Apr 2008, Hannes Magnusson wrote: > > > bjori Wed Apr 9 11:58:37 2008 UTC > > > > Modified files: (Branch: PHP_5_2) > > /pecl/intl php_intl.c > > /pecl/intl/grapheme grapheme_string.c grapheme.h > > Log: > > Fix reflection > > > > > > > PHP_FE( grapheme_extract, grapheme_3_args ) > > - PHP_FE( grapheme_extractB, grapheme_3_args ) > > + PHP_FE( grapheme_extractb, grapheme_3_args ) > > Uh, what happened to descriptive function names here. What in ****'s > name is the difference between grapheme_extract and grapheme_extractb? According to the docs[1][2]: _extractb: "maximum number of bytes to return" _extract: "maximum number of grapheme clusters to return" removing _extractb and adding a 4th parameter, $return, to _extract(..., GRAPHEME_BYTES|GRAPHEME_CLUSTER) sounds way better though. -Hannes [1] http://docs.php.net/manual/en/function.grapheme-extract.php [2] http://docs.php.net/manual/en/function.grapheme-extractb.php