Re: New Extension: tcc
| From: | Tsukasa Hamano | Date: | Tue, 22 Apr 2008 10:02:25 +0000 |
| Subject: | Re: New Extension: tcc | ||
| References: | 1 2 3 4 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5398@lists.php.net to get a copy of this message | ||
Hi,
At Mon, 21 Apr 2008 17:40:34 +0400,
Antony Dovgal wrote:
>
> Looks good in general.
>
> There is whitespaces/tabs problem (we use tabs for indentation) and
> I would also remove unused code (commented out ext_skel leftovers,
> php_printf's for debugging, unused PHP_R*() functions etc).
>
Thank you for the checking.
I just fixed indent and deleted unused code.
How about this?
http://64.71.152.180/tcc-0.1.1.tar.gz
--
KLab Inc. K Laboratory
Tsukasa Hamano <hamano@klab.org>