Re: Re: [ANNOUNCEMENT] tcc-0.1.2 (devel) Released.

From:	Antony Dovgal	Date:	Fri, 25 Apr 2008 07:24:08 +0000
Subject:	Re: Re: [ANNOUNCEMENT] tcc-0.1.2 (devel) Released.
References:	1	Groups:	php.pecl.dev
Request:	Send a blank email to pecl-dev+get-5413@lists.php.net to get a copy of this message

On 25.04.2008 08:24, Tsukasa Hamano wrote:

Hi,
The new PECL package tcc-0.1.2 (devel) has been released at http://pecl.php.net/.
This is my first release. if there is a problem, please teach me.

Several questions: - What happens if you call tcc_delete() twice on the same resource? - There error message in tcc_run() doesn't seem to be correct, or is it? I'd recommend using php_error_docref(), it adds function name automagically. I prepared a patch for you: http://dev.daylessday.org/diff/tcc_patch.diff It mostly removes ext_skel leftovers and fixes coding style, but it also changes RETURN_FALSE to return (which is identical to RETURN_NULL()) in case of invalid arguments and seems to be de-facto standard. I also took the liberty to change the way tcc_run() accepts its arguments. -- Wbr, Antony Dovgal