Re: Re: [ANNOUNCEMENT] tcc-0.1.2 (devel) Released.
| From: | Tsukasa Hamano | Date: | Mon, 28 Apr 2008 12:28:00 +0000 |
| Subject: | Re: Re: [ANNOUNCEMENT] tcc-0.1.2 (devel) Released. | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5416@lists.php.net to get a copy of this message | ||
Hi,
At Fri, 25 Apr 2008 11:24:08 +0400,
Antony Dovgal wrote:
>
> Several questions:
> - What happens if you call tcc_delete() twice on the same resource?
It's dangerous to call tcc_delete() of libtcc twice.
I'll fix to be prohibit call tcc_delete() same resource.
> - There error message in tcc_run() doesn't seem to be correct, or is it?
> I'd recommend using php_error_docref(), it adds function name automagically.
>
I'll replace to php_error_docref() after investigating it.
> I prepared a patch for you:
> http://dev.daylessday.org/diff/tcc_patch.diff
> It mostly removes ext_skel leftovers and fixes coding style, but it also changes
> RETURN_FALSE to return (which is identical to RETURN_NULL()) in case of invalid
> arguments and seems to be de-facto standard.
> I also took the liberty to change the way tcc_run() accepts its arguments.
>
I commited your patch, it will apply from next release.
Thanx for your advice.
--
KLab Inc. K Laboratory
Tsukasa Hamano <hamano@klab.org>