Re: New PECL package request: fuse
| From: | Antony Dovgal | Date: | Tue, 18 Nov 2008 08:49:05 +0000 |
| Subject: | Re: New PECL package request: fuse | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-5895@lists.php.net to get a copy of this message | ||
On 18.11.2008 03:13, Bob Carroll wrote:
> I posted the main C file here: http://pastebin.ca/1259854
This doesn't seem right:
...
/* Every user-visible function in PHP should document itself in the source */
/* {{{ proto string confirm_fuse_compiled(string arg)
Return a string to confirm that the module is compiled in */
PHP_FUNCTION(fuse_main)
...
Also there is no need to use WRONG_PARAM_COUNT; after zend_parse_parameters(),
as the latter already spits out an error when something wrong is passed,
so just 'return;' is enough.
Do you have any test-cases and/or examples?
--
Wbr,
Antony Dovgal