Re: new extension wanna feedback.
| From: | Kalle Sommer Nielsen | Date: | Fri, 10 Apr 2009 14:46:53 +0000 |
| Subject: | Re: new extension wanna feedback. | ||
| References: | 1 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-6302@lists.php.net to get a copy of this message | ||
Hi Goodyork
2009/4/10 Goodyork Lion <goodyork@gmail.com>:
> Hi all,
>
> I just implement a new extension for php-erlang communicate , wanna
> feedback from all.
> checkout here http://code.google.com/p/mypeb/
Have you tried to compile your code with --enable-maintainer-zts ?
Theres a few bogus code parts like this:
if(ZEND_NUM_ARGS() TSRMLS_CC ==0){
This is incorrect and will cause a syntax error in ZTS, simply remove
the TSRMLS_CC macro here, its only needed in functions that require
the tsrm parameters for thread safety.
You seems to be using the C++ single line comment, which ofcourse only
will work with a C++ compiler.
You may also want to add arginfo for Reflection to your end_function_entry.
>
> York Liu
> www.phpx.com
>
--
Kalle Sommer Nielsen
kalle@php.net