Re: new extension wanna feedback.

Hi Kalle, On Fri, Apr 10, 2009 at 10:46 PM, Kalle Sommer Nielsen <kalle@php.net>wrote: > Hi Goodyork > > 2009/4/10 Goodyork Lion <goodyork@gmail.com>: > > Hi all, > > > > I just implement a new extension for php-erlang communicate , wanna > > feedback from all. > > checkout here http://code.google.com/p/mypeb/ > > Have you tried to compile your code with --enable-maintainer-zts ? > Theres a few bogus code parts like this: > if(ZEND_NUM_ARGS() TSRMLS_CC ==0){ > > This is incorrect and will cause a syntax error in ZTS, simply remove > the TSRMLS_CC macro here, its only needed in functions that require > the tsrm parameters for thread safety. > > You seems to be using the C++ single line comment, which ofcourse only > will work with a C++ compiler. Thanks so much! I just fixed it . I'm new to php extension actually, this extension is NOT full-function tested in my own environment. > > You may also want to add arginfo for Reflection to your end_function_entry. I didn't read any about this before your email . Just found an article about it, http://cweiske.de/howto/hackingphp5/Hacking.html . > > > > > York Liu > > www.phpx.com > > > > > > -- > Kalle Sommer Nielsen > kalle@php.net > York Liu www.phpx.com