Re: New Stomp extension

Thanks for your comments, everything should now be ok. It compile on 5.2 and 5.3. Pierrick 2009/10/28 Alexey Zakhlestin <indeyets@gmail.com>: > > On 28.10.2009, at 1:03, Pierrick Charron wrote: > >> I am Pierrick Charron, a French developer. I would like to submit the >> Stomp extension (Streaming Text Orientated Messaging Protocol) which >> is used by many popular Message brokers such as ActiveMQ. >> >> This extension contains an OOP stomp client and a procedural stomp >> client (You'll find the user space documentation here: >> http://www.adoy.net/stomp/doc). I plan to put it under the >> PHP License >> 3 >> >> It would be very appreciated if I could get an SVN account (pierrick) >> and karma to upload this extension and maintain it. >> >> Here is the source code: >> http://www.adoy.net/stomp/stomp.tgz >> >> Any feedback/suggestions will be welcome > > 1) code doesn't build on php 5.3. Would be nice to verify that > 2) you mix indentation. part of the time you use spaces, part of the time > tabs > 3) in couple of places you put all of "if (condition) action;" on the same > line > > other than that — looks fine ;)