Re: New Stomp extension

Thank you Israel, I'll install windows and VC++ on one of my machine this week to compile it and help me solve all the windows problems. Pierrick 2009/10/28 Israel Ekpo <israelekpo@gmail.com>: > Hi Pierrick, > > It compiles but I got the following warnings when I compiled it. > > You may have to fix some of them in order to compile on Windows when C++ > compilers are used. > > stomp.c: In function 'stomp_new': > stomp.c:37: warning: request for implicit conversion from 'void *' to > 'struct stomp_t *' not permitted in C++ > stomp.c:41: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c: In function 'stomp_send': > stomp.c:147: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:147: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:148: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:148: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:154: warning: declaration of 'index' shadows a global declaration > /usr/include/string.h:310: warning: shadowed declaration is here > stomp.c:160: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:160: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:161: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:161: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:164: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:164: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:167: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:167: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:174: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:174: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:175: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:175: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:176: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:176: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:179: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:179: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:182: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c:182: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c: In function 'stomp_read_buffer': > stomp.c:232: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c: In function 'stomp_read_line': > stomp.c:283: warning: request for implicit conversion from 'void *' to 'char > *' not permitted in C++ > stomp.c: In function 'frame_destroy': > stomp.c:315: warning: control reaches end of non-void function > stomp.c: In function 'stomp_read_frame': > stomp.c:353: warning: declaration of 'p2' shadows a previous local > stomp.c:343: warning: shadowed declaration is here > stomp.c:371: warning: request for implicit conversion from 'void *' to > 'const char *' not permitted in C++ > stomp.c:371: warning: request for implicit conversion from 'void *' to > 'const char *' not permitted in C++ > stomp.c:371: warning: request for implicit conversion from 'void *' to > 'const char *' not permitted in C++ > stomp.c:343: warning: unused variable 'p2' > stomp.c:379: warning: declaration of 'length' shadows a previous local > stomp.c:324: warning: shadowed declaration is here > stomp.c:382: warning: implicit declaration of function 'ealloc' > stomp.c:382: warning: cast from function call of type 'int' to non-matching > type 'char *' > stomp.c:388: warning: comparison between signed and unsigned > stomp.c: In function 'stomp_valid_receipt': > stomp.c:415: warning: ISO C90 forbids mixed declarations and code > > > On Wed, Oct 28, 2009 at 9:07 AM, Pierrick Charron <pierrick@webstart.fr> > wrote: >> >> Thanks for your comments, >> >> everything should now be ok. It compile on 5.2 and 5.3. >> >> Pierrick >> >> 2009/10/28 Alexey Zakhlestin <indeyets@gmail.com>: >> > >> > On 28.10.2009, at 1:03, Pierrick Charron wrote: >> > >> >> I am Pierrick Charron, a French developer. I would like to submit the >> >> Stomp extension (Streaming Text Orientated Messaging Protocol) which >> >> is used by many popular Message brokers such as ActiveMQ. >> >> >> >> This extension contains an OOP stomp client and a procedural stomp >> >> client (You'll find the user space documentation here: >> >> http://www.adoy.net/stomp/doc). I plan to put it >> >> under the PHP License >> >> 3 >> >> >> >> It would be very appreciated if I could get an SVN account (pierrick) >> >> and karma to upload this extension and maintain it. >> >> >> >> Here is the source code: >> >> http://www.adoy.net/stomp/stomp.tgz >> >> >> >> Any feedback/suggestions will be welcome >> > >> > 1) code doesn't build on php 5.3. Would be nice to verify that >> > 2) you mix indentation. part of the time you use spaces, part of the >> > time >> > tabs >> > 3) in couple of places you put all of "if (condition) action;" on the >> > same >> > line >> > >> > other than that — looks fine ;) >> >> -- >> PECL development discussion Mailing List (http://pecl.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > "Good Enough" is not good enough. > To give anything less than your best is to sacrifice the gift. > Quality First. Measure Twice. Cut Once. >