Re: php_yaf a PHP framework extension

On 10/13/2010 08:15 AM, 惠新宸 wrote:

Hi: any feedback is appreciated

Some suggestions while reading through the code: - your code is not C89 compatible (variable decls) - and I guess it's not C++ compiler compatible (use of "this") - is there really any need to preface non-public members with underscores? - Yaf::__construct() sets/reads YAF_G(instance) Why not use the singleton pattern and a static Yaf::$instance property? - yaf_config_instance calls PHP_FUNCTION(parse_ini_file) Why don't you directly call zend_parse_ini_file()? - Yaf_Controller::redirect enforces 302 response code Why not let PHP figure out which code to use best? - Why do you register all those list destructors? - registering a logo is a bit... So far, Mike