Re: Re: php_yaf a PHP framework extension

hi, 5.2 does not support VC9. Use 5.3 for that. Cheers, On Fri, Oct 15, 2010 at 8:49 AM, 惠新宸 <huixinchen@baidu.com> wrote: > Hi: >  I am working on compiling Yaf in Vs2008 with php-5.2.14. > >  and found >   call  zend_register_internal_class_ex  cause a segment fault. > >  any idea? > > > thanks > > Best regards > > 惠新宸     Xinchen Hui > http://www.laruence.com/ > > On 10/14/2010 14:48, Michael Wallner wrote: >> >> On 10/13/2010 08:15 AM, 惠新宸 wrote: >>> >>> Hi: >>> >>> any feedback is appreciated >> >> Some suggestions while reading through the code: >> >> - your code is not C89 compatible (variable decls) >> >> - and I guess it's not C++ compiler compatible (use of "this") >> >> - is there really any need to preface non-public members with underscores? >> >> - Yaf::__construct() sets/reads YAF_G(instance) >>    Why not use the singleton pattern and a static Yaf::$instance property? >> >> - yaf_config_instance calls PHP_FUNCTION(parse_ini_file) >>    Why don't you directly call zend_parse_ini_file()? >> >> - Yaf_Controller::redirect enforces 302 response code >>    Why not let PHP figure out which code to use best? >> >> - Why do you register all those list destructors? >> >> - registering a logo is a bit... >> >> >> So far, >> Mike >> >> -- >> PECL development discussion Mailing List (http://pecl.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > -- > PECL development discussion Mailing List (http://pecl.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org