Re: Introduction, Drizzle PECL module
| From: | Andrew Hutchings | Date: | Thu, 17 Feb 2011 21:46:07 +0000 |
| Subject: | Re: Introduction, Drizzle PECL module | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-8004@lists.php.net to get a copy of this message | ||
Hi Ulf,
On 17/02/11 18:42, Ulf Wendel wrote:
Am 17.02.2011 10:05, schrieb Andrew Hutchings:Indeed, and I thank you guys for helping me out. I apologise if it came across as if I wasn't grateful.Yes, but the easy alternative for us is to fork it on Launchpad and send patches to PECL upstream. We can then use Launchpad for DEBs and RPMs.Pierre is neither the owner of PECL nor did he give you a final "no". He pointed out good practise of giving the maintainer a chance to raise his voice - in public. As a sign of good will, Pierre applied your patch almost immediately.
If you have more patches, please attach to bugs and send reminders about the bugs to the list for the time until everybody feels happy with giving you repository access or changing the maintainer. I'm sure one or the other guy on the list will apply the patches for you. Providing tests makes it, as usual, more likely for your patch to be accepted.Of course, I've actually just submitted a new patch which adds an additional function and some test cases which is at: http://pecl.php.net/bugs/bug.php?id=22560 No rush on it though. The fact that trunk now compiles and is testable now is fantastic, we have had some issues with one of the new data types in other languages we really needed to test in PHP as part of QA. So many thanks for committing that first patch so quick. I will try and get a load of new tests added asap so we can use it as part of our regression suite. Kind Regards -- Andrew Hutchings - LinuxJedi - http://www.linuxjedi.co.uk/