Re: Re: Introduction and new PHP extension: php_rsync

Hey Johannes, thanks for the feedback. > Best is not to bundle the LGPL code (or bundle it in a way that two > distinct libraries (.so, .dynlib, .dll) are being created. There is another branch in the git repository, where the librsync isn't bundled. So i think there is no issue with the license cause this branch is supposed to be taken into the pecl. The branch with the bundled librsync would stay in the github and could be used by people who prefer to compile the php_rsync from source as a single .so . Another point for the bundled version is to compile it easier on windows, where creating shared objects means some additional overhead, hence no librsync version for windows exists. There was docref errors before exceptions. The exceptions came as preparation for the OO interface. We would let the exceptions stay as an OO interface will come anyways. The other fixes you've suggested do make sense anyway, but are trivial and can be done quickly. Best regards Anatoliy Belsky