Re: [Patch] GeoIP Tests

Mike, I'll take care of any changes, please open bug reports and attach patches. I'll review and commit. Thanks, Olivier On Mon, Jun 6, 2011 at 10:38 AM, Pierre Joye <pierre.php@gmail.com> wrote: > hi, > > please use pecl-dev to talk about pecl's packages. > > Thanks for your work! > > On Mon, Jun 6, 2011 at 4:37 PM, Mike Willbanks <pencap@gmail.com> wrote: >> I've gone through the GeoIP extension and ensured all of the tests now pass. >> >> Bug Report: http://pecl.php.net/bugs/bug.php?id=22749 >> Patch File: >> http://blog.digitalstruct.com/patches/geoip-svn-tests.patch.txt >> >> Also, it looks like the GeoIP extension is based on an extremely old >> version, I am going to start looking to update this to get all of the new >> constants that should exist into the extension. >> A slight amount of behavior changed and should have been noted previously >> for the test as "CA" is no longer a valid country code w/o a region in the >> timeZone.c area of the GeoIP C API. >> >> Someone with karma want to review and apply the patch for the tests? >> >> Regards, >> >> Mike >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | ‡Ú·é) > x€¯17DÊ2http://www.libgd.org > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- http://www.olivierhill.ca/