Re: Pecl request for new extension
| From: | Joshua Thijssen | Date: | Fri, 30 Mar 2012 19:13:23 +0000 |
| Subject: | Re: Pecl request for new extension | ||
| References: | 1 2 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-9271@lists.php.net to get a copy of this message | ||
Michael Wallner wrote:
> Looks good at a first glance, except... there's one show-stopper:
> According to coding-standards the method names should me 'studlyCaps':
That's an easy fix I guess I assume:
PHP_METHOD(shout, set_metadata) {
should become:
PHP_METHOD(shout, setMetadata) {
Is that correct?
> And BTW, it's interesting for me that 90% of all new extensions have
> adopted the *_object_new_ex() approach...
I think a lot (including me) are based on other extension's work, so
probably some functionality on occasion is obsoleted (for instance, line
46, there is still a exception class entry defined, but never used). And
I have no idea what the *ptr is actually used for otherwise (haven't
found that info, and I haven't dived into the zend-api long enough to
figure that out yet).