Re: Pecl request for new extension

From: Date: Fri, 30 Mar 2012 21:42:29 +0000
Subject: Re: Pecl request for new extension
References: 1 2  Groups: php.pecl.dev 
Request: Send a blank email to pecl-dev+get-9273@lists.php.net to get a copy of this message
On Fri, 30 Mar 2012 23:36:27 +0200, Patrick Allaert <patrick.allaert@gmail.com> wrote:
In you function declaration (php_shout_get_handler_string(), php_shout_get_handler_long(), php_shout_get_handler_ulong(), ...), none of those are using the TSRMLS_DC macro. example: 
    static void
php_shout_get_handler_string(INTERNAL_FUNCTION_PARAMETERS, const char *(*func)(shout_t *)) should become: 
    static void
php_shout_get_handler_string(INTERNAL_FUNCTION_PARAMETERS, const char *(*func)(shout_t *) TSRMLS_DC) which will give the additional void ***tsrm_ls parameter to you function when building with ZTS.
This is not correct, as INTERNAL_FUNCTION_PARAMETERS already includes TSRMLS_DC. -- Gustavo Lopes

« previous php.pecl.dev (#9273) next »