Re: Re: [Gallery-devel] [Fwd: PHP 5.2.2RC1 testing]
| From: | Marcus Boerger | Date: | Sat, 14 Apr 2007 15:48:07 +0000 |
| Subject: | Re: Re: [Gallery-devel] [Fwd: PHP 5.2.2RC1 testing] | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-28167@lists.php.net to get a copy of this message | ||
Hello Ilia,
I disagree here. We need to get as close to 100% coverage. But still
that does not mean we get erverything. Running other tests now gives us
the ability to catch much more stuff. And also simply getting 100%
coverage does not mean we get all code paths. And also not necessarily
check for all inputs.... So IMO we should do both.
best regards
marcus
Saturday, April 14, 2007, 4:47:41 PM, you wrote:
> Running tests without valgrind is a bad idea IMO, even when the test
> returns expected results the background code could be corrupting
> memory, consequence of which may not need seen inside the test
> itself. I'd rather run fewer tests with valgrind, then more tests but
> without the full benefit of comprehensive testing.
> On 14-Apr-07, at 9:13 AM, Nuno Lopes wrote:
>> Although the machine isn't very fast, the upgrade to Etch has
>> provided a *huge* speedup. For example the PHP 5.2 build time was
>> cut in about 15 hours. If we don't run those tests with valgrind
>> the machine should be able to run them ok.
>>
>> Nuno
>>
>>
>>> Can our existing gcov machine handle that many tests? Having to
>>> wait a week for results would be somewhat inconvenient... Perhaps
>>> we need to upgrade this machine if we plan to extend the test suit?
>>>
>>>
>>> On 11-Apr-07, at 6:12 PM, Derick Rethans wrote:
>>>
>>>> On Thu, 12 Apr 2007, Antony Dovgal wrote:
>>>>
>>>>> On 04/12/2007 01:57 AM, Derick Rethans wrote:
>>>>>> On Wed, 11 Apr 2007, Marcus Boerger wrote:
>>>>>>
>>>>>>> Hello Sebastian,
>>>>>>>
>>>>>>> is this an area where you could help nuno and me? Meaning
>>>>>>> setting up
>>>>>>> PHPUnit and integrating it in the automatic test runs?
>>>>>>
>>>>>> I could offfer plenty of code/tests here.
>>>>>
>>>>> That would be really great.
>>>>
>>>> We've like 2500 tests for our stuff, but not the machine power
>>>> to run it
>>>> all under valgrind :) Some of it wouldn't be able to run without
>>>> some
>>>> database configuration or servers though.
>>>>
>>>> I already experimented with exporting our test results to some
>>>> database
>>>> as well, but that's still quite primitive (and unfortunately not
>>>> reachable from outside our network).
>>>>
>>>> regards,
>>>> Derick
>>
>> --
>> PHP Quality Assurance Mailing List
>> <http://www.php.net/>
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
> Ilia Alshanetsky
Best regards,
Marcus