Re: cvs: php4(PHP_4_0_7) /ext/zlib zlib.c

On Fri, 23 Nov 2001, Rui Hirokawa wrote: > Sorry. No need for :) > I think this is a critical bug, but I should discuss before commit. yeah, but PHP 4.1.0 will be released from the php_4_0_7RC3 tag, so your change wouldn't have made it in into the release anyway. If you really think it's needed, and that you are very sure it is okay, it is possible to reset the tag on these file to the new version. However, I think that it should be tested as part of an RC cyclus, as any untested (by QA) code should. I cc-ed this to the PHP-QA list, so that we can have this discussion there. regards, Derick PHP QA > > > hirokawa Thu Nov 22 21:37:27 2001 EDT > > > > > > Modified files: (Branch: PHP_4_0_7) > > > /php4/ext/zlib zlib.c > > > Log: > > > restriction is relaxed because output handler couldn't be used even if > > > zlib.output_compression is set to off. > > > > Why did you merge this to the release branch without having a discussion > > on php-dev first? This branch has just had his final RC, and the change > > will not be in PHP 4.1.0. (But will be in bug fix releases from the 4.1 > > branch).