Re: tests/quicktester.inc

From: Date: Tue, 16 Apr 2002 23:45:29 +0000
Subject: Re: tests/quicktester.inc
References: 1  Groups: php.qa 
Request: Send a blank email to php-qa+get-5156@lists.php.net to get a copy of this message
quite an amount of tests is broken right now (ext/standard/tests/strings/trim.phpt and wordwrap.phpt for example), and they're the tests that include("tests/quicktester.inc") instead of evaluating the results themselves. The reason is simple: TOP_SRCDIR is not in include_path. This (and other issues) could be solved by making the tests use a slightly modified php.ini-dist which would be created (and deleted again) by make test. Easier solution would be to modify the include() calls to stick $_ENV['TOP_SRCDIR'] in front of "tests/quicktester.inc". This however doesn't solve other issues, like register_argc_argv = off in the installed php.ini, which would have to be addressed separately... Although, that would be easy enough. Which one do you prefer?
argc/argv are turned off on purpose at this point. It would probably be best short-term to use -c or something to call those scripts that require different php.ini settings to function properly... Long-term, since there are bound to be a *LOT* of different test scripts with different needs for php.ini, perhaps it would make sense for "make test" to: 1. check for foo.ini and use that as php.ini for foo.phpt 2. Use no php.ini at all for anything else. Just a suggestion... -- Got Music? http://l-i-e.com/artists.htm

« previous php.qa (#5156) next »