Re: tests/quicktester.inc

> Date: Tue, 16 Apr 2002 18:45:29 -0500 > To: php-qa@lists.php.net > From: Richard Lynch <ceo@l-i-e.com> > Subject: Re: [PHP-QA] tests/quicktester.inc > > >quite an amount of tests is broken right now > >(ext/standard/tests/strings/trim.phpt and wordwrap.phpt for example), > >and they're the tests that include("tests/quicktester.inc") instead of > >evaluating the results themselves. The reason is simple: TOP_SRCDIR is > >not in include_path. > > > >This (and other issues) could be solved by making the tests > >use a slightly modified php.ini-dist which would be created (and deleted > >again) by make test. > > > >Easier solution would be to modify the include() calls to stick > >$_ENV['TOP_SRCDIR'] in front of "tests/quicktester.inc". This however > >doesn't solve other issues, like register_argc_argv = off in the > >installed php.ini, which would have to be addressed separately... > >Although, that would be easy enough. > > > >Which one do you prefer? > > argc/argv are turned off on purpose at this point. well, the test target says ... $(top_builddir)/sapi/cli/php -c php.ini-dist ... so that would be ok. but if argc/argv is off on purpose, what does the argc/argv test actually test? (I haven't read that one, just wondering) > It would probably be best short-term to use -c or something to call > those scripts that require different php.ini settings to function > properly... > > Long-term, since there are bound to be a *LOT* of different test > scripts with different needs for php.ini, perhaps it would make sense > for "make test" to: > > 1. check for foo.ini and use that as php.ini for foo.phpt > 2. Use no php.ini at all for anything else. -- FreeBSD 4.4-STABLE 7:41AM up 1 day, 20:53, 10 users, load averages: 0.04, 0.03, 0.00