Fwd: [PHP-DEV] run-tests.php esacapeshellarg, portability
| From: | Lukas Kahwe Smith | Date: | Sun, 10 Aug 2008 17:17:38 +0000 |
| Subject: | Fwd: [PHP-DEV] run-tests.php esacapeshellarg, portability | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-64418@lists.php.net to get a copy of this message | ||
Begin forwarded message:
From: "Pierre Joye" <pierre.php@gmail.com> Date: 10. August 2008 17:31:41 GMT+02:00 To: "PHP Internals" <internals@lists.php.net> Subject: [PHP-DEV] run-tests.php esacapeshellarg, portability hi! While fixing broken tests (linux or win), I found that shell arguments are manually escaped. Using escapeshellargs is more portable and avoid duplicate tests only to fix shell argument issues (& usage for example). Here is a patch to add escapeshellarg usage: http://pierre.libgd.org/patches/runtests_5_3_escapeshellarg.patch.txt A couple of tests need changes, like: inisetting="foo" will become inisetting=foo or inisetting="" to inisetting= Please test the patch or let me know if you have any objection :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.phpLukas Kahwe Smith mls@pooteeweet.org