Re: cvs: php-src /ext/session/tests 020.phpt

On Sun, Sep 7, 2008 at 7:01 PM, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > On Sun, Sep 7, 2008 at 16:40, Pierre Joye <pierre.php@gmail.com> wrote: >> On Sun, Sep 7, 2008 at 4:13 PM, Hannes Magnusson >> <hannes.magnusson@gmail.com> wrote: >> >>> ; The separator used in PHP generated URLs to separate arguments. >>> ; Default is "&". >>> ;arg_separator.output = "&amp;" >>> >>> >>> Is this the same bug as \ in doublequotes bug/feature? >> >> Not sure which bug/feature you are refering to. But the problem here >> is to use double quotes in the ini settings section of a phpt as >> escape characters instead of using escapeshellargs in run-tests.php > > > Ahh! > > So: >>> Does arg_separator.output="&amp;" in php.ini not work on windows - or >>> is this a bug in run-tests.php? >> >> It does not. run-tests should take care of escaping the cmd line >> arguments arguments using escapeshellargs. We can then use: > > The "It does not [work]" is wrong. It *does* work in *php.ini*, just > not in run-tests.php? Not sure if it works in php.ni as I did not test it :) run-tests.php calls php.exe and passes it the ini arguments using the -d cmd line option, and the double quotes are wrongly interpreted. My patch fixes the issue but I did not get the time to dig through all tests to remove the unnecessary double quotes. It would rock if someone from the QA team could give me a hand :) Cheers, -- Pierre http://blog.thepimp.net | http://www.libgd.org