Re: cvs: php-benchmarks / deltablue.php

Hi Alexander, Great work. I've only had time for a quick review, so heres what I've seen so far. They're very minor: - The syntax is a bit off: sometimes spaces, sometimes tabs, and inconsistent indentation. Likewise, the - The grammar in your comments is a little unusual, using the first person. Can you explain why you went this way? - The loop at the end goes 155 times. How did you get to this number? How long is the benchmark supposed to run for? Thanks, Paul On Mon, May 4, 2009 at 3:39 PM, Alexander Hjalmarsson <hjalle@php.net> wrote: > hjalle          Mon May  4 14:39:31 2009 UTC > >  Modified files: >    /php-benchmarks     deltablue.php >  Log: >  Ported from Java implementation > > -- > PHP Quality Assurance Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > -- Paul Biggar paul.biggar@gmail.com