RE: [PHP-QA] cvs: php-benchmarks / deltablue.php

Hi! Sorry about the syntax thing. I did use a pretty print software but the input was inconsistent so I guess the output came out that way as well. I'll use your tool next time, but I just have that option on my linux computer :) Do anyone know of any plugin to Eclipse that handles this? The grammar in the comments are a result of a bad copy-paste usage from the java-source. I guess he (Mario Wolzcko I believe) had a habit of doing so or thought it was the best way. I could change it if that’s needed. I took the loop-figure from the SunSpider-test (http://svn.webkit.org/repository/webkit/trunk/SunSpider/tests/v8-deltablue.js) and I have no idea where they got that figure from. I guess it can be a good idea to lower it in the beginning at least so it doesn't time-out like Ólafur said. // Alexander -----Original Message----- From: Paul Biggar [mailto:paul.biggar@gmail.com] Sent: den 4 maj 2009 17:02 To: Alexander Hjalmarsson Cc: php-qa@lists.php.net Subject: Re: [PHP-QA] cvs: php-benchmarks / deltablue.php Hi Alexander, Great work. I've only had time for a quick review, so heres what I've seen so far. They're very minor: - The syntax is a bit off: sometimes spaces, sometimes tabs, and inconsistent indentation. Likewise, the - The grammar in your comments is a little unusual, using the first person. Can you explain why you went this way? - The loop at the end goes 155 times. How did you get to this number? How long is the benchmark supposed to run for? Thanks, Paul On Mon, May 4, 2009 at 3:39 PM, Alexander Hjalmarsson <hjalle@php.net> wrote: > hjalle Mon May 4 14:39:31 2009 UTC > > Modified files: > /php-benchmarks deltablue.php > Log: > Ported from Java implementation > > -- > PHP Quality Assurance Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php > -- Paul Biggar paul.biggar@gmail.com -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php