Re: new phpruntests and the use of private

Stefan Priebsch wrote:

I'd like to formally suggest that private not be used in the source code of phpruntests, and protected be the exclusive encapsulation PPP thing used.

You're right, that is something we should change. OK - I'll add to my TODOs to do a global edit

One word of warning, though, for Greg: the internal APIs of phpruntests are far from stable, we are currently working on getting phpruntests to produce exactly the same results as the old run-tests. When that is achieved (and thanks to Zoe we are really close) Close for a defined set of tests - those that will be executed if PHP 53 is configured without any additional options.

This means 7772 tests - known differences on Linux are listed here: http://wiki.php.net/qa/runtests/difference To make this work I have had to make more changes to tests than to code, the new code is much stricter. For example I have: - Corrected failing SKIPIF - Corrected failing CLEAN - Changed tests which used --SKIP-- to use --SKIPIF-- - Changed tests which used --INIT-- to use --INI-- - Removed blank test sections This was probably between 40 - 60 tests, which is not bad out of 7772. I expect to have to do more of this on tests we aren't executing now.

I expect a _lot_ of refactoring to happen inside phpruntests, so I would not recommend relying on any internal API of phpruntests today. Some areas more than others I think. The basic inner workings are (under testcase and sections) are structurally OK, at least, I'm finding it easy to maintain. The configuration is less good and needs some rework and we need to fix exception handling. Actually Stefan is right - there is still a lot to do :-)

Zoe