Re: svn: /php/php-benchmarks/trunk/benchweb/installers/phpbb/ bench/benchmark.php benchmark.php phpbb-3.0.5.patch setup.php

On Fri, Aug 14, 2009 at 14:01, Nuno Lopes<nlopess@php.net> wrote: >>> Modified: php/php-benchmarks/trunk/benchweb/installers/phpbb/setup.php >>> =================================================================== >>> --- php/php-benchmarks/trunk/benchweb/installers/phpbb/setup.php >>> 2009-08-14 09:48:28 UTC (rev 287281) >>> +++ php/php-benchmarks/trunk/benchweb/installers/phpbb/setup.php >>> 2009-08-14 09:54:52 UTC (rev 287282) >>> @@ -3,6 +3,20 @@ >>> $dir = "phpBB3"; >>> require "../../config.php"; >>> >>> +//Download phpBB3 >>> +shell_exec("wget >>> >>> http://d10xg45o6p6dbl.cloudfront.net/projects/p/phpbb/phpBB-3.0.5.tar.bz2"); >> >> wget isn't the "download tool of choice" on all platforms, may I >> suggest something along the lines of >> >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/pear/fetch.php?revision=260513&view=markup >> instead? > > What a complex thing, when you can just do a "copy($url, '.');". Anyway, > the The only reason to use wget is to get the progress info, which is what that fetch.php does > This project is not supposed to be as universal as PEAR, and so we don't > care about these kind of details. If you are deploying this beast, of course Fair enough. -Hannes