Re: IMAP tests

Hello ! I updated my previous patch with new IMAP tests. This patch is a diff with latest SVN version. It has 16 new tests and 3 modified (imap_body, imap_gc_error and imap_open_error). http://www.ajeux.com/phptests/patch_imap_php53-php6.patch This patch has been tested successfully against following versions: php5.3-200910161430: OK php6.0-200910161430: OK PHP 5.2 requires many modifications, mainly because of warnings about parameter count (message in 5.2 is 'wrong parameter count', and in 5.3/6.0 it is 'function() expects at least X parameters, Y given'). You can apply this patch to branch PHP_5_3 and trunk. The code Coverage increased to 68.5% on ext/imap (was 45% before). This extension has still some failed tests (5 here), but none is part of this patch. Any feedback welcome! Olivier P.S. What is the policy concerning having an access to SVN (just tests/ folders) ? 2009/9/22 Olivier Doucet <webmaster@ajeux.com> > Hi, > > However, the patch doesn't include the new tests. Can you please send them >> again? (you can just zip them and upload them somewhere) > > > Well, it seems I had some trouble using diff correctly :) > > Here is the patch with only new tests: > http://www.ajeux.com/phptests/extimap-newtests.diff > > I also modified 3 existing tests to add code coverage: > imap_body.phpt > imap_gc_error.phpt > imap_open_error.phpt > > The diff file (for these 3 files only) is available here: > http://www.ajeux.com/phptests/extimapmodifications.diff > > > Dir on these two .diff are not correct. Patch can be applied with patch -p1 > in ext/imap/tests dir (tested successfully). > > > >> [...] If it doesn't, please file a bug report with a test case. >> > > Ok fine I'll fill a bug report this evening. > > Olivier > >