Re: IMAP tests

From: Date: Fri, 16 Oct 2009 22:36:44 +0000
Subject: Re: IMAP tests
References: 1 2 3 4 5 6  Groups: php.qa 
Request: Send a blank email to php-qa+get-65405@lists.php.net to get a copy of this message
I updated my previous patch with new IMAP tests. This patch is a diff with latest SVN version. It has 16 new tests and 3 modified (imap_body, imap_gc_error and imap_open_error). http://www.ajeux.com/phptests/patch_imap_php53-php6.patch This patch has been tested successfully against following versions: php5.3-200910161430: OK php6.0-200910161430: OK PHP 5.2 requires many modifications, mainly because of warnings about parameter count (message in 5.2 is 'wrong parameter count', and in 5.3/6.0 it is 'function() expects at least X parameters, Y given'). You can apply this patch to branch PHP_5_3 and trunk. The code Coverage increased to 68.5% on ext/imap (was 45% before).
Thanks for your work. Sounds great!
P.S. What is the policy concerning having an access to SVN (just tests/ folders) ?
I would suggest you to apply for an svn account (at http://php.net/svn-php.php), so that you can commit the tests yourself. Sometimes it's difficult to find someone with the time to review tests/patches. Thanks, Nuno

« previous php.qa (#65405) next »