Re: bug51709_2.phpt - remove the slash from the --EXPECTF-- section?
| From: | eyal . t | Date: | Sun, 31 Oct 2010 06:19:18 +0000 |
| Subject: | Re: bug51709_2.phpt - remove the slash from the --EXPECTF-- section? | ||
| References: | 1 2 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65659@lists.php.net to get a copy of this message | ||
Just noticed that bug51709_1 suffers too from the exact same problem.
On 10/28/2010 08:10 PM, Patrick ALLAERT wrote:
Hi, 2010/10/28 eyal.t<eyal.t@zend.com>:Hi, php-5.3.3/tests/basic/bug51709_2.phpt contains the following --EXPECTF-- section: --EXPECTF-- Parse error: syntax error, unexpected T_GOTO, expecting T_STRING in %s/bug51709_2.php on line %d shouldn't the slash be removed, as to allow the test to pass on windows?: --EXPECTF-- Parse error: syntax error, unexpected T_GOTO, expecting T_STRING in %sbug51709_2.php on line %d thx, EyalIt looks like a valid solution to make it pass under windows too. Attached a patch which solves this issue in different places. Anyone against I commit this? Regards,