RE: [PHP-QA] bug51709_2.phpt - remove the slash from the --EXPECTF-- section?

And so does ext/standard/test/php_ini_loaded_file : --EXPECTF-- string(%d) "%s/tmp-php.ini" The slash can also be replaced with %e ________________________________________ From: patrick.allaert@gmail.com [patrick.allaert@gmail.com] on behalf of Patrick ALLAERT [patrickallaert@php.net] Sent: Monday, November 08, 2010 11:30 AM To: Eyal Teutsch Cc: php-qa@lists.php.net Subject: Re: [PHP-QA] bug51709_2.phpt - remove the slash from the --EXPECTF-- section? This has been fixed in revision 305192. Thanks for reporting Eyal! Regards, -- Patrick Allaert --- http://code.google.com/p/peclapm/ - Alternative PHP Monitor 2010/10/31 eyal.t <eyal.t@zend.com>: > Just noticed that bug51709_1 suffers too from the exact same problem. > > On 10/28/2010 08:10 PM, Patrick ALLAERT wrote: >> >> Hi, >> >> 2010/10/28 eyal.t<eyal.t@zend.com>: >>> >>> Hi, >>> >>> php-5.3.3/tests/basic/bug51709_2.phpt contains the following --EXPECTF-- >>> section: >>> >>> --EXPECTF-- >>> Parse error: syntax error, unexpected T_GOTO, expecting T_STRING in >>> %s/bug51709_2.php on line %d >>> >>> shouldn't the slash be removed, as to allow the test to pass on windows?: >>> >>> --EXPECTF-- >>> Parse error: syntax error, unexpected T_GOTO, expecting T_STRING in >>> %sbug51709_2.php on line %d >>> >>> thx, >>> Eyal >> >> It looks like a valid solution to make it pass under windows too. >> Attached a patch which solves this issue in different places. >> >> Anyone against I commit this? >> >> Regards, >> > > > -- > PHP Quality Assurance Mailing List <http://www.php.net/> > To unsubscribe, visit: http://www.php.net/unsub.php -- PHP Quality Assurance Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php