Re: Re: php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client test fails as of unexpected deprecated output

Dear Eyal, short question: why not $s = explode('.', $cv) (with single quotes)? Yes, it is only one line, but how many lines with double quotes has to be executed for a complete test run? Best regards, Kai -------- Original Message -------- Subject: Re: [PHP-QA] Re: php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client test fails as of unexpected deprecated output From: Eyal Teutsch <eyal.t@zend.com> To: Patrick ALLAERT <patrickallaert@php.net>, php-qa@lists.php.net Date: 29.11.2010 14:45

Change tested and looks ok. I haven't been given commit access yet, so for now I can only send patches -:) On 11/29/2010 03:22 PM, Patrick ALLAERT wrote:

2010/11/29 Eyal Teutsch<eyal.t@zend.com>:

Following Daniel Convissor suggestion, suggested patch uses explode instead of the deprecated split: Index: ext/pdo_oci/tests/pdo_oci_attr_client.phpt =================================================================== --- ext/pdo_oci/tests/pdo_oci_attr_client.phpt (revision 305821) +++ ext/pdo_oci/tests/pdo_oci_attr_client.phpt (working copy) @@ -17,7 +17,7 @@ $cv = $dbh->getAttribute(PDO::ATTR_CLIENT_VERSION); var_dump($cv); -$s = split("\.", $cv); +$s = explode(".", $cv); if ($s[0]>= 10&& count($s)> 1&& $s[1]>= 2) { if (count($s) != 5) { echo "Wrong number of values in array\nVersion was: "; thx, Eyal

Looks good, did you tested your change and does it pass? In such a case you can commit it! (Given that you received commit access to the tests). Regards,