Re: Re: php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client test fails as of unexpected deprecated output

Felipe has merged this: http://svn.php.net/viewvc?view=revision&revision=305963 He also merged http://svn.php.net/viewvc?view=revision&revision=305964 Chris On 11/28/2010 10:54 PM, Eyal Teutsch wrote:

Following Daniel Convissor suggestion, suggested patch uses explode instead of the deprecated split: Index: ext/pdo_oci/tests/pdo_oci_attr_client.phpt =================================================================== --- ext/pdo_oci/tests/pdo_oci_attr_client.phpt (revision 305821) +++ ext/pdo_oci/tests/pdo_oci_attr_client.phpt (working copy) @@ -17,7 +17,7 @@ $cv = $dbh->getAttribute(PDO::ATTR_CLIENT_VERSION); var_dump($cv); -$s = split("\.", $cv); +$s = explode(".", $cv); if ($s[0] >= 10 && count($s) > 1 && $s[1] >= 2) { if (count($s) != 5) { echo "Wrong number of values in array\nVersion was: "; thx, Eyal On 11/08/2010 04:21 PM, eyal.t wrote:

Hi, The test pdo_oci_attr_client under php-5.3.3/ext/pdo_oci/tests seems to fail as of the following unexpected output: / Deprecated: Function split() is deprecated in /var/www/php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client.php on line 14/ Suggest to add to the --EXPECTF-- section such line as follows: Index: /home/eyal/php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client.phpt =================================================================== --- /home/eyal/php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client.phpt (revision 305201) +++ /home/eyal/php-5.3.3/ext/pdo_oci/tests/pdo_oci_attr_client.phpt (working copy) @@ -39,5 +39,6 @@ ?> --EXPECTF-- ATTR_CLIENT_VERSION: string(%d) "%d.%s" +Deprecated: Function split() is deprecated in %s on line %d Version OK, so far as can be portably checked Done if there are no objections, will commit this change. thx, Eyal

-- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/