Re: skipif section in ext/standard/tests/streams/bug46024.phpt misses 'skip' string
| From: | Felipe Pena | Date: | Sat, 04 Dec 2010 15:57:30 +0000 |
| Subject: | Re: skipif section in ext/standard/tests/streams/bug46024.phpt misses 'skip' string | ||
| References: | 1 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-65691@lists.php.net to get a copy of this message | ||
Fixed, thanks. :)
2010/12/2 Eyal Teutsch <eyal.t@zend.com>
> Hi,
>
> test ext/standard/tests/streams/bug46024.phpt seems to miss the string
> 'skip' in it's SKIPIF section:
>
> --SKIPIF--
> <?php if (!getenv('TEST_PHP_EXECUTABLE')) die("TEST_PHP_EXECUTABLE not
> defined"); ?>
>
>
> Here's the suggested patch (no svn commit privileges yet):
>
> Index: php-5.3.3/ext/standard/tests/streams/bug46024.phpt
> ===================================================================
> --- php-5.3.3/ext/standard/tests/streams/bug46024.phpt (revision 305902)
> +++ php-5.3.3/ext/standard/tests/streams/bug46024.phpt (working copy)
> @@ -1,7 +1,7 @@
> --TEST--
> Bug #46024 stream_select() doesn't return the correct number
> --SKIPIF--
> -<?php if (!getenv('TEST_PHP_EXECUTABLE')) die("TEST_PHP_EXECUTABLE not
> defined"); ?>
> +<?php if (!getenv('TEST_PHP_EXECUTABLE')) die("skip - TEST_PHP_EXECUTABLE
> not defined"); ?>
> --FILE--
> <?php
> $php = getenv('TEST_PHP_EXECUTABLE');
>
>
> thx,
>
> Eyal
>
> --
> PHP Quality Assurance Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>
--
Regards,
Felipe Pena