Re: Unit tests
| From: | Ferenc Kovacs | Date: | Fri, 09 Dec 2011 13:34:43 +0000 |
| Subject: | Re: Unit tests | ||
| References: | 1 2 3 4 5 6 7 8 9 | Groups: | php.qa |
| Request: | Send a blank email to php-qa+get-66023@lists.php.net to get a copy of this message | ||
On Fri, Dec 9, 2011 at 2:17 PM, Jean-Marc Fontaine <jm@jmfontaine.net>wrote:
> sorry, I missed that little piece of information. :)
>
> My fault. I did not said that upfront.
>
> it seems that you already have karma for php/php-src/*/tests (see
>
> http://svn.php.net/viewvc/SVNROOT/global_avail?view=markup#l247) so
> you
> can go ahead and commit those patches yourself, if you would like to.
>
> I wondered if I was allowed to commit and if I was supposed to. In the
> mean time Pattrick Allaert has committed my tests.
>
> Is there some kind of review to be sure my unit tests are not crap? Even,
> if they are not. Off course. ;)
>
> Thanks for your help,
>
> Jean-Marc
>
>
usually we trust those people with karma, so next time go ahead and commit
it, worst thing that can happen that your tests fail, and somebody will
tell you that you should be more careful. :)
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu