Re: Unit tests

2011/12/9 Ferenc Kovacs <tyra3l@gmail.com>: > On Fri, Dec 9, 2011 at 2:17 PM, Jean-Marc Fontaine <jm@jmfontaine.net>wrote: > >> sorry, I missed that little piece of information. :) >> >> My fault. I did not said that upfront. >> >> it seems that you already have karma for php/php-src/*/tests (see >> >> http://svn.php.net/viewvc/SVNROOT/global_avail?view=markup#l247) so >> you >> can go ahead and commit those patches yourself, if you would like to. >> >> I wondered if I was allowed to commit and if I was supposed to. In the >> mean time Pattrick Allaert has committed my tests. >> >> Is there some kind of review to be sure my unit tests are not crap? Even, >> if they are not. Off course. ;) >> >> Thanks for your help, >> >> Jean-Marc >> >> > usually we trust those people with karma, so next time go ahead and commit > it, worst thing that can happen that your tests fail, and somebody will > tell you that you should be more careful. :) I reviewed your test and can confirm there were not crap at all ;) Feel free to commit them yourself, in case of questions or doubts you can always ask the php-qa mailing list as you did. Remember to backport tests committed to trunk to relevant branches such as PHP_5_4, PHP_5_3. Cheers, Patrick