RE: [SMARTY-DEV] more abstraction committed

Monte, Thanks a lot for this changes! Refactoring is depressingly boring isn't it? The numbers look very good and I know many of my applications will se a nice performance improvement. Thanks! About vegas: No poker but do we have a Smarty-guy who plays bridge? We can make the Smarty-bridge-team :-) Luis > -----Original Message----- > From: Monte Ohrt [mailto:monte@ispi.net] > Sent: Thursday, May 08, 2003 6:47 PM > To: messju mohr > Cc: Smarty Dev > Subject: Re: [SMARTY-DEV] more abstraction committed > > > On Thu, 2003-05-08 at 16:21, messju mohr wrote: > > > > > I mostly abstracted things used during the compile phase. > The other > > > things (like filepath rendering) I left to keep optimum speed. (I > > > think the filepath rendering should be cached instead of > computed on > > > each page call. That's another project :-) > > > > you mean in _get_plugin_filepath() ? i thought about this also. the > > is_readable()s are cached by php anyway but it's worth a > test, if this > > can be speeded up. > > That too, but I was referring to path creation for compiled > templates and cache files. They could be cashed instead of > assembled each time. It would need to store it in some sort > of hash file, so I'm not too sure which way to go with it yet. > > > i must admit i am a bit sheepish about breaking smarty down > to so many > > files, i think every stat/include adds overhead, but i love > to let the > > numbers speek for themselves. maybe there is some benefit > in a third > > parameter to _execute_core_function(): $subject, or $group > then files > > would be located by subject and not only by > core-function-name, so we > > don't need a file for each sub-aspect. but i think i have > to bechmark > > and compare such an approach. > > I thought about grouping them into files instead of by > function, but since this is mostly stuff during compile phase > I wasn't too concerned. This also keeps things neatly > modular, but that is not a priority. > > > > > anyway: i'll do some testing of your latest commits soon. > if las vegas > > is regarded as some kind of holiday have fun, if otherwise have > > success :) > > I play in pool tournaments each year. As a bonus, the World > Series of Poker is going on too, which I'd love to partake one day ;-) > > Monte > > > > -- > Smarty Development Mailing List (http://smarty.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php >