Re: more abstraction committed

Monte Ohrt schrieb in php.smarty.dev: > This has reduced the size of Smarty.class.php from 88K down to 52K. > There is still quite a bit more that can be abstracted, but this is a > good start. Hi, I made some Tests with my applikation, because I had some performance problems with cached templates. They would slower and slower with every new generation... But this problem only occurs when compile_check is enabled and is possibly a bug. With compile_check disabled for me a non-cached page is a little bit slower as in 2.5.0 and for cached pages I see no difference: http://4bc.info/smarty/profiling.html For the possibly bug when compile_check is enabled with the current CVS version I look in the cache file. The problem is, that every cache regeneration blows up the cache header: First generated cache header (deserialized) of the cached template 'login.status.top.tpl': Array ( [template] => Array ( [0] => login.status.top.tpl [1] => debug_cache.tpl ) [config] => Array ( [0] => lang_en.conf [1] => lang_en.conf [2] => lang_en.conf [3] => lang_en.conf [4] => lang_en.conf [5] => lang_en.conf [6] => lang_en.conf [7] => lang_en.conf [8] => lang_en.conf [9] => lang_en.conf [10] => lang_en.conf [11] => lang_en.conf ) [timestamp] => 1052660824 [expires] => 1052660829 ) After some (maybe 3) regenerations: Array ( [template] => Array ( [0] => login.status.top.tpl [1] => debug_cache.tpl [2] => login.status.top.tpl [3] => debug_cache.tpl [4] => login.status.top.tpl [5] => debug_cache.tpl [6] => login.status.top.tpl [7] => debug_cache.tpl ) [config] => Array ( [0] => lang_en.conf [1] => lang_en.conf [2] => lang_en.conf [3] => lang_en.conf [4] => lang_en.conf [5] => lang_en.conf [6] => lang_en.conf [7] => lang_en.conf [8] => lang_en.conf [9] => lang_en.conf [10] => lang_en.conf [11] => lang_en.conf ) [timestamp] => 1052661651 [expires] => 1052661661 ) Also the 11 'lang_en.conf' entrys looks a little bit redundant... ;-) Greetings, Thomas. -- http://4bconsult.de