Re: [SMARTY-DEV] Incorrect newline counters
| From: | Antony Dovgal | Date: | Sat, 29 May 2004 20:49:26 +0000 |
| Subject: | Re: [SMARTY-DEV] Incorrect newline counters | ||
| References: | 1 | Groups: | php.smarty.dev |
| Request: | Send a blank email to php-smarty-dev+get-2320@lists.php.net to get a copy of this message | ||
On Sat, 29 May 2004 23:39:49 +0400
Dmitry Koteroff <spam@koteroff.ru> wrote:
> Hello.
>
> Smarty do not preserve line numbers while compiling the template.
> When an error occurs, PHP shows line number in compiled file, and
> it does not correspond line number in the source template.
>
><skipped>
>
> and $a is undefined, I get notice not in line 8, but in other.
> Resulting template contains:
> a) superfluous \n's - in the headder comments /* compiled from
> ...*/, and after plugins require_once's;
> b) insufficient spaces - {strip} processed incorrectly, it glues
> its body, replacing \n by '', but not by <?php\n?>
>
> What do you thing about all that? If I write the patch which will
> correct line numbers, will you include it in production version?
Imho a patch, which will allow to handle correctly all mismatched Smarty
tags would be better, than a patch, which will add/remove new lines in
compiled template.
--
Wbr,
Antony Dovgal aka tony2001
tony2001@phpclub.net || antony@dovgal.com