Re: Re[4]: [SMARTY-DEV] Incorrect newline counters
| From: | boots | Date: | Wed, 02 Jun 2004 13:47:25 +0000 |
| Subject: | Re: Re[4]: [SMARTY-DEV] Incorrect newline counters | ||
| References: | 1 | Groups: | php.smarty.dev |
| Request: | Send a blank email to php-smarty-dev+get-2376@lists.php.net to get a copy of this message | ||
--- Dmitry Koteroff <delete@koteroff.ru> wrote:
> B> What's the problem here anyhow? I'm not against getting this
> B> "fixed", but what is broken? Is anyone complaining about the
> B> current behaviour?
DK> Aha.
DK>
DK> -------------
DK> xxx
DK> {if $foo}
DK> bar
DK> {/if}
DK> yyy
DK> -------------
DK>
DK> Result:
DK>
DK> -------------
DK> xxx
DK> bar
DK> yyy
DK> -------------
DK>
[..snip..]
DK> What do you say about the example above? Do you use its
DK> side-effect in your templates? Doubtful.
Yes, this is a known behaviour that is suboptimal. What do you expect I
have done to-date? I worked around it. Will my workarounds continue to
work should the behaviour be "corrected"? Again, is there a chorus of
voices complaining about this?
> B> You may as well go into php-dev and tell them that you have a
> B> simple patch for "correcting" PHP's case insensitivity
> B> problem. It's not that you are wrong, its that people don't
> B> care and moreso, they don't want the change.
DK> Most of people people want generally nothing (except of whiskey
DK> or vodka, of course). But it is not a cause not to accomplish
DK> Smarty.
You are most correct. Still, neither is that a reason to make changes.
> B> So unless you can present a series of well defined test-cases that
> show
> B> how your changes will have absolutely, gauranteed, no effect on
> the
> B> output, I can't see anyone supporting your changes.
DK> I'll do it, and I am ready to improve Smarty "space behavour" at
DK> all (together with line number synchronization), but I need
DK> sanctions.
Well, in principle, that is a good thing. All I really ask is that
you present your changes in a way that clearly shows how the behaviour
will be modified (or prove that it won't be changed). It appears that
there is now some discussion and documentation occuring around that
point and that is far more acceptable than a patch to a sensitive area
that merely purports to be an improvement without providing even test
cases let alone a thorough examination of the issues.
Greetings,
xo boots
__________________________________
Do you Yahoo!?
Friends. Fun. Try the all-new Yahoo! Messenger.
http://messenger.yahoo.com/