Re: Grammar issues reporting

On Thu, Jul 31, 2014 at 10:53 AM, Andrea Faulds <ajf@ajf.me> wrote: > > On 31 Jul 2014, at 18:48, Hannes Magnusson <hannes.magnusson@gmail.com> wrote: > >> github is a mirror of the git.php.net repository, it is not the upstream repo. >> this "integration" you speak of likely means the issue referencing >> from commits to github issue tracker. > > Yep, that’s nice. > >> This will clearly make absolutely no sense when using the upstream >> repo on git.php.net as these issue number do not exist and do not >> autolink or close. > > I don’t fully understand your objection. As GitHub just pulls from git.php.net, GitHub would > presumably still auto link and close. Obviously you don’t have that nice linkage on the > git.php.net viewer, but somehow I suspect more people use GitHub to browse the source than > git.php.net. I might be wrong, of course. Besides, the issue exists anyway as *GitHub* doesn’t > auto link bugs.php.net bugs. > > Is this really a problem? I suppose we could hold an email vote or something on whether people > would rather use one or the other. (In which case, to avoid list spamming, perhaps one person could > collect the votes.) > I'm unclear on what you are unclear on, and what is the problem you are attempting to resolve. The issue# to git commit and vice-versa is implemented in the PHP.net infrastructure. You report tickets at: https://bugs.php.net/report.php?package_name=PHP+Language+Specification You browse tickets at: https://bugs.php.net/search.php?cmd=display&status=Open&package_name%5B%5D=PHP+Language+Specification You reference ticket with "bug #xyz" in the commit message. You push to git.php.net. The ticket will be updated to include a reference to the commit. You browse the git history and see a ticket# in the commit logs... You look it up on bugs.php.net/<ticket> If you reference a GitHub issue# in the commit message then looking up that reference on bugs.php.net/ is not going to work. This is the same issue as when corporates have their own issue trackers and reference their tickets in our repositories. These references make no sense for PHP.net devs and should not be used. The GitHub repo is a fake mirror. It cannot be pushed to (well, it can, but then you fuckup a lot of things, which is why "noone" has push karma to the repos). If you require further explanation lets take it off list so we don't have to waste everyone else time. -Hannes